usbdev: Split usbdev descriptor information #10480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please mark this as a breaking change and add a note in Impact that |
xiaoxiang781216
added
the
breaking change
The class device only handles descriptor information specific to the class, and shared descriptor information is passed through parameters and handled by the composite driver. Signed-off-by: zhangyuan21 <zhangyuan21@xiaomi.com>
xiaoxiang781216
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a partial modify for issue #10433, This modification can unify the handling of configuration descriptors related to the device.
Split usbdev descriptor information, let the class device only handles descriptor information specific to the class, and shared descriptor information is passed through parameters and handled by the composite driver.
Impact
composite_initialize arguments have changed and board specific composite initialization needs to be updated.
before:
FAR void *composite_initialize(uint8_t ndevices, FAR struct composite_devdesc_s *pdevices);after:
FAR void *composite_initialize(FAR const struct usbdev_devdescs_s *devdescs, FAR struct composite_devdesc_s *pdevices, uint8_t ndevices);Testing
sim:usbdev and bes borad with adb