Mpfs IHC bugfixes and perf enhancements #10484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jani Paalijarvi <jani.paalijarvi@unikie.com>
Remove unnecessary VQID shifting (16 -> 0). Give an error if RPTUN init fails.
acassis
approved these changes
Sep 5, 2023
xiaoxiang781216
approved these changes
Sep 5, 2023
RPMSG is associated with the use of HPWORK / LPWORK queues. After sending a message to the remote end (Linux), the system waits for an ack before proceeding. Unfortunately this may take sometimes more time than one would expect. Ack waiting is also unnecessary: nothing is done with that information. Even worse, the net_lock() is also held during the blocked time so it blocks other network stacks that are unrelated to this. Also reorganize the mpfs_opensbi_*.S so that the trap handler is easily relocated in the linker .ld file without the need to relocate the utils.S. This makes it easier to separate the files into own segments. The trap file should be located in the zero device. Moreover, provide support for simultaneous ACK and message present handling capabilities in both directions. There are times when both bits are set but only other is being handled. In the end, the maximum throughput of the RPMSG bus increases easily 10-20% or even more. Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
eenurkka
force-pushed
the
mpfs-ihc-perf
branch
from
082e24c
to
a248c12
Compare
xiaoxiang781216
approved these changes
Sep 6, 2023
|
let's ignore macOS temp ci failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MPFS IHC has a few bugs. If encountered, the RPMSG bus gets stuck. While fixing the issues, better performance is also achieved though rewriting parts of the code.
Impact
All MPFS systems using IHC / RPMSG
Testing
Overnight testing with SW that utilizes all the RPMSG bandwidth