Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtensa/esp32s3: Add support to TWAI/CANBus controller #10521

Merged

Conversation

eren-terzioglu
Copy link
Contributor

Summary

xtensa/esp32s3: Add support to TWAI/CANBus controller

Impact

Only ESP32S3

Testing

ESP32-S3 DevkitC-1 with using esp32s3-devkit:twai configuration and can example

Note: I tested with CAN loopback mode under the Device Drivers->CAN Driver Support and wired CAN RX to CAN TX with a jumper cable (Default pins are pin 0 and pin 2).

@acassis
Copy link
Contributor

acassis commented Sep 7, 2023

@eren-terzioglu very well done!

Did you run: $ ./tools/refresh.sh --silent --defaults all to normalize the boards?

Seems like some boards are out of sync:

  Normalize esp32s3-devkit/twai
23,24d22
< CONFIG_ESP32S3_TWAI=y
< CONFIG_EXAMPLES_CAN=y
26a25
> CONFIG_ESP32S3_TWAI=y
27a27
> CONFIG_EXAMPLES_CAN=y
Saving the new configuration file
HEAD detached at pull/10521/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   boards/xtensa/esp32s3/esp32s3-devkit/configs/twai/defconfig

@eren-terzioglu
Copy link
Contributor Author

New config normalized, thanks for the suggestion

@eren-terzioglu very well done!

Did you run: $ ./tools/refresh.sh --silent --defaults all to normalize the boards?

Seems like some boards are out of sync:

  Normalize esp32s3-devkit/twai
23,24d22
< CONFIG_ESP32S3_TWAI=y
< CONFIG_EXAMPLES_CAN=y
26a25
> CONFIG_ESP32S3_TWAI=y
27a27
> CONFIG_EXAMPLES_CAN=y
Saving the new configuration file
HEAD detached at pull/10521/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   boards/xtensa/esp32s3/esp32s3-devkit/configs/twai/defconfig

@xiaoxiang781216 xiaoxiang781216 merged commit a26996f into apache:master Sep 7, 2023
23 of 26 checks passed
@jerpelea jerpelea added this to To-Add in Release Notes - 12.3.0 Sep 26, 2023
@jerpelea jerpelea moved this from To-Add to done in Release Notes - 12.3.0 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants