Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/sim: Guard frame buffer related setting in SIM_X11FB #10606

Merged
merged 1 commit into from Sep 19, 2023

Conversation

xiaoxiang781216
Copy link
Contributor

Summary

and remove SIM_VNCSERVER

Impact

sim x11 fb

Testing

ci

@pkarashchenko
Copy link
Contributor

So flock issue is still reported.

@xiaoxiang781216
Copy link
Contributor Author

So flock issue is still reported.

no, this patch is pushed before flock patch get merged.

@xiaoxiang781216
Copy link
Contributor Author

rebase the latest master.

@pkarashchenko
Copy link
Contributor

Please fix

 /usr/bin/ld: nuttx.rel: in function `nx_server':
nxmu_start.c:(.text.nx_server+0x25): undefined reference to `up_fbinitialize'
/usr/bin/ld: nxmu_start.c:(.text.nx_server+0x33): undefined reference to `up_fbgetvplane'
/usr/bin/ld: nuttx.rel: in function `fb_register':
(.text.fb_register+0x41): undefined reference to `up_fbinitialize'
/usr/bin/ld: (.text.fb_register+0x59): undefined reference to `up_fbgetvplane'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:372: nuttx] Error 1
make: *** [tools/Unix.mk:537: nuttx] Error 2
make: Target 'all' not remade because of errors.

@xiaoxiang781216
Copy link
Contributor Author

Done.

and remove SIM_VNCSERVER

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
Copy link
Contributor Author

@acassis this patch is too.

@GUIDINGLI GUIDINGLI merged commit 15e7847 into apache:master Sep 19, 2023
25 of 26 checks passed
@jerpelea jerpelea added this to To-Add in Release Notes - 12.3.0 Sep 26, 2023
@jerpelea jerpelea moved this from To-Add to arch in Release Notes - 12.3.0 Sep 27, 2023
@jerpelea jerpelea moved this from arch to done in Release Notes - 12.3.0 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants