Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we are using newlib as libm, we can consider newlib-esp32 for esp32 hardware. An it contains some optimizations for esp32 hardware. Besides this change, two small issues has been fixed.
Impact
Using a seperated config option to switch and default is n. So no impact to normal case.
For enable newlib-esp32 case, it has a little performance improvement for float calculation.
Testing
Write a piece of simple test code and update
example/hello
app as below:Use esp32-devkitc:nsh config and enable below options
Here is the test result:
For the case of using default newlib (sourceware.org)
For the case of using newlib-esp32:
We can see the newlib-esp32 case is a little better in performance than the default.