bcm_driver: revert packed attribute for scan structure

[zhhyu7]

Summary

These structures need to be aligned with the firmware, packed_struct will cause the scan information from Wi-Fi firmware not to be parsed by broadcom Wi-Fi driver. Therefore, we need to remove the packed_struct of the structure associated with the scan information.

Impact

Testing

Cortex-M55 and bcm43xxx chipset

[acassis]

Please include more details in the commit log message. I think the original patch you submitted was trying to packed the struct to optimize memory usage and end up creating other issues. It is important to describe better for other people understand why you already tried and why it failed.

[acassis]

Please include a more informative log message (similar to your Summary)

[zhhyu7]

Please include more details in the commit log message. I think the original patch you submitted was trying to packed the struct to optimize memory usage and end up creating other issues. It is important to describe better for other people understand why you already tried and why it failed.

Done.

[pkarashchenko]

Shouldn't this be handled by explicit struct padding or insertion of reserved byte members? I mean that packing option may change depending on arch and compiler, so this case is most likely tuned for 32bit arch with gcc/llvm.

[pkarashchenko]

Ideally the packed and non-packed structures should be the same, so we do not rely on compiler settings. There is also a flexibility in usage of explicit pointer cast from byte array to structure type and packed structures will avoid unaligned pointer usage.