add wchar api implementation #10739
add wchar api implementation #10739
Conversation
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
| ****************************************************************************/ | ||
|
|
||
| static const unsigned char g_table[] = | ||
| { |
There was a problem hiding this comment.
how do you plan to maintain these tables?
There was a problem hiding this comment.
should I place the content g_table[] to a separate header file ?
There was a problem hiding this comment.
The code base comes from musl:
https://github.com/bminor/musl/blob/master/src/ctype/wide.h
https://github.com/bminor/musl/blob/master/src/ctype/nonspacing.h
https://github.com/bminor/musl/blob/master/src/ctype/wcwidth.c#L3-L9
@extinguish just reformat the code to follow NuttX coding style.
so, it may better to ask musl owner to improve the design and comment, so we can incorporate the improvement back.
There was a problem hiding this comment.
it's our problem to reformat imported code and make maintenance harder.
it isn't a problem in musl.
There was a problem hiding this comment.
the original code also lack any information about these two tables. Why do you consider it is the reformat problem?
There was a problem hiding this comment.
at least it's easier to copy changes from the upstream if we don't reformat.
There was a problem hiding this comment.
Yes, but the code incorporated into nuttx has to conform the coding style which we must follow.
BTW, this is the rule enforced by ci, the rule relaxation needs to be discussed in dev@ list.
Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Summary
add wchar api: fputws, putwc, putwchar, fputwc, wcswidth, wcwidth, wcswcs, wcstok, wcsstr, wcsspn, wcspbrk implementation.
Impact
Testing