Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32-S3-EYE: I2C, SPI and LCD support #10884

Merged
merged 7 commits into from Oct 12, 2023

Conversation

casaroli
Copy link
Contributor

@casaroli casaroli commented Oct 10, 2023

Summary

Adds I2C, SPI and LCD support for the esp32-s3-eye.

This is the second of a series of PRs to make the esp32s3-eye peripherals usable under NuttX.

Impact

Now we can draw things on the screen

Testing

Manually tested in my local esp32-s3-eye. Runs lvgldemo with the lcd config

@casaroli casaroli force-pushed the esp32s3-eye-i2c-spi branch 4 times, most recently from c5a94d8 to cb1de9f Compare October 10, 2023 11:56
@casaroli casaroli marked this pull request as ready for review October 10, 2023 12:04
@casaroli casaroli changed the title ESP32-S3-EYE: I2C, SPI and LCD ESP32-S3-EYE: I2C, SPI and LCD support Oct 10, 2023
@acassis
Copy link
Contributor

acassis commented Oct 10, 2023

@casaroli there is a warning that our CI transform in error:

 ====================================================================================
Configuration/Tool: esp32s3-eye/lcd
------------------------------------------------------------------------------------
  Cleaning...
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
  Configuring...
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
  Building NuttX...
port/lv_port_lcddev.c: In function 'lcddev_update_thread':
Error: port/lv_port_lcddev.c:87:7: error: variable 'errcode' set but not used [-Werror=unused-but-set-variable]
   87 |   int errcode = 0;
      |       ^~~~~~~
cc1: all warnings being treated as errors

Please remove errcode or use it

@casaroli casaroli marked this pull request as draft October 10, 2023 16:58
If only I2C1 is configured but not I2C0, gcc is giving a warning,
so we suppress it.
@casaroli casaroli force-pushed the esp32s3-eye-i2c-spi branch 4 times, most recently from 1353a5e to 393d526 Compare October 11, 2023 19:09
This IO is not exposed in any headers and it is only used for LCD.

So we don't expose it as gpio device.
@casaroli casaroli force-pushed the esp32s3-eye-i2c-spi branch 2 times, most recently from 77835a4 to 2f524ab Compare October 11, 2023 19:20
@casaroli casaroli marked this pull request as ready for review October 11, 2023 19:22
@tmedicci
Copy link
Contributor

Do you think Is it possible to update the entry of this board on the docs? The idea is to include these new defconfigs and a simple usage example.

@casaroli
Copy link
Contributor Author

Do you think Is it possible to update the entry of this board on the docs? The idea is to include these new defconfigs and a simple usage example.

yes, I plan on updating the documentation in a separate PR.

@acassis acassis merged commit 0f56d34 into apache:master Oct 12, 2023
26 checks passed
@jerpelea jerpelea added this to To-Add in Release Notes - 12.4.0 Dec 27, 2023
@jerpelea jerpelea moved this from To-Add to processed in Release Notes - 12.4.0 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants