Update Fix more generic for platforms that do not have execinfo.h #10910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve multiplatform code with __has_include.
|
@xiaoxiang781216 @acassis I updated #10905 |
acassis
approved these changes
Oct 14, 2023
xiaoxiang781216
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simulator build fails on non-GLIBC platform #5621 #5623.
On platforms where the execinfo.h file is missing, the Gnulib substitute implementation is just a stub, and does nothing.
https://www.gnu.org/software/gnulib/manual/html_node/execinfo_002eh.html
Improve multiplatform code with __has_include.
https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005finclude.html
Impact
On Linux with glibc: There should be no impact.
On other platforms: Enable simulator compilation.
Testing
We tested on platform Alpine linux sim:nsh on github sim:lua