esp32: Add wifishare board config and documentation #10961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
approved these changes
Oct 17, 2023
acassis
force-pushed
the
master
branch
2 times, most recently
from
d0eca2f
to
a4893be
Compare
|
@xiaoxiang781216 the macro HTONL(match->target) is returning different types of integer depending on architecture and compiler. What should be the right fix here? |
|
Thank you @xiaoxiang781216 I applied temporarily your patch here just to confirm it will fix the issue. If the CI pass I remove this commit, apply your PR and rebase my PR with it. |
let's reuse your pr to simplify the process. |
acassis
force-pushed
the
master
branch
2 times, most recently
from
95d9a5e
to
26a4a52
Compare
Signed-off-by: Alan C. Assis <acassis@gmail.com>
so the printf can give the unambiguous format specifier Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
esp32: Add wifishare board config and documentation
Impact
Users will be able to use ESP32 board as Access Point and Base Station at same time and share Internet connection!
Testing
ESP32-Devkit
Thanks Zhe Weng for helping!