Revert "make/archive: Use the full path name when matching or storing… #11007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is already the same PR working on this issue, let's wait for this commit to be merged |
anchao
approved these changes
Oct 24, 2023
xiaoxiang781216
approved these changes
Oct 24, 2023
|
Depends on: apache/nuttx-apps#2138 |
|
need rerun CI when apache/nuttx-apps#2138 was merged |
anchao
approved these changes
Oct 27, 2023
|
@SPRESENSE Please rebase this PR |
… names in the archive" This reverts commit 563125f.
SPRESENSE
force-pushed
the
pullrequest-811
branch
from
4d552ae
to
5cb3872
Compare
|
rebase done. |
pkarashchenko
approved these changes
Oct 27, 2023
jerpelea
approved these changes
Oct 27, 2023
tmedicci
added a commit
to tmedicci/incubator-nuttx
that referenced
this pull request
Nov 6, 2023
After apache#11007 was merged, the path for some files changed, requiring the linker to be fixed to make it run from the internal memory once again.
acassis
pushed a commit
that referenced
this pull request
Nov 6, 2023
After #11007 was merged, the path for some files changed, requiring the linker to be fixed to make it run from the internal memory once again.
freakishness
pushed a commit
to freakishness/incubator-nuttx
that referenced
this pull request
Feb 18, 2024
After apache#11007 was merged, the path for some files changed, requiring the linker to be fixed to make it run from the internal memory once again.
halyssonJr
pushed a commit
to halyssonJr/nuttx
that referenced
this pull request
Apr 10, 2024
After apache#11007 was merged, the path for some files changed, requiring the linker to be fixed to make it run from the internal memory once again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Revert #10395 (commit 563125f)
The
Poption ofarcommand has the following description.Thus, it cannot extract or strip archive files with path names directly.
If the
Poption is not mandatory for NuttX, it should avoid mixing the same filename in one archive file withoutPoption.Impactc
None
Testing
Build: Pass