tun: Fix the error of calling tun_close when tun_txavail or tun_txavail_work is executed #11009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…un_txavail_work is executed" This reverts commit 0f1a49b. Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
acassis
approved these changes
Oct 24, 2023
…il_work is executed When tun_txavail_work is running, switch to tun_close thread and priv->lock will be destroyed, then switch back to tun_txavail_work thread, an error will occur when nxmutex_unlock(&priv->lock) Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
anchao
approved these changes
Oct 24, 2023
xiaoxiang781216
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When tun_txavail_work is running, switch to tun_close thread and priv->lock will be destroyed, then switch back to tun_txavail_work thread, an error will occur when nxmutex_unlock(&priv->lock).
The previous modified mode was found to have a deadlock(net_lock and tun_lock) problem after stress testing, revert the previous patch, the new implementation was fix the error and avoids the deadlock issue.
Impact
Testing
Cortex-M33