Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/configure.c and tools/sethost.sh Add CONFIG_EXPERIMENTAL for configure windows native #11098

Merged
merged 1 commit into from Oct 31, 2023

Conversation

simbit18
Copy link
Contributor

@simbit18 simbit18 commented Oct 30, 2023

Summary

Add CONFIG_EXPERIMENTAL for configure windows native

Impact

There should be no impact.

Testing

We tested on platform MSYS2 and Alpine linux

Add CONFIG_EXPERIMENTAL for configure windows native
@xiaoxiang781216 xiaoxiang781216 merged commit 1bcf01e into apache:master Oct 31, 2023
26 checks passed
@xiaoxiang781216
Copy link
Contributor

@simbit18 but why not enable CONFIG_EXPERIMENTAL from defconfig?

@masayuki2009
Copy link
Contributor

@simbit18

Please remove the duplicated commit message next time.

commit 1bcf01e7a8f8e18a52b34eea92616c92467499c2
Author: simbit18 <101105604+simbit18@users.noreply.github.com>
Date:   Tue Oct 24 14:27:15 2023 +0200

    Add CONFIG_EXPERIMENTAL for configure windows native

    Add CONFIG_EXPERIMENTAL for configure windows native

@simbit18
Copy link
Contributor Author

simbit18 commented Oct 31, 2023

@simbit18 but why not enable CONFIG_EXPERIMENTAL from defconfig?

@xiaoxiang781216 Because the Windows native configuration depends on
CONFIG_EXPERIMENTAL.
If CONFIG_EXPERIMENTAL is not enable, the default Windows Build Environment is set to Cygwin.
https://github.com/apache/nuttx/blob/master/Kconfig#L159

@xiaoxiang781216
Copy link
Contributor

Ok, but why not remove EXPERIMENTAL from WINDOWS_NATIVE directly? Since it works fine with your environment and initial contributor's.

@simbit18
Copy link
Contributor Author

simbit18 commented Nov 1, 2023

@xiaoxiang781216 It is still preferable to leave marked as EXPERIMENTAL because it cannot be assured to be fully functional.

@xiaoxiang781216
Copy link
Contributor

Ok

@jerpelea jerpelea added this to To-Add in Release Notes - 12.4.0 Dec 27, 2023
@jerpelea jerpelea moved this from To-Add to tool in Release Notes - 12.4.0 Jan 8, 2024
@jerpelea jerpelea moved this from tool to processed in Release Notes - 12.4.0 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants