drivers/foc: return scaling factor for phase currents and BEMF via ioctl #11176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raiden00pl
force-pushed
the
foc_iphase
branch
2 times, most recently
from
8c03dcd
to
4cdbd46
Compare
raiden00pl
force-pushed
the
foc_iphase
branch
2 times, most recently
from
6d8eaa2
to
9783803
Compare
These values are board-specific properties that must be known on the application side. Until now, these values had to be hardcoded on the application side.
raiden00pl
force-pushed
the
foc_iphase
branch
from
9783803
to
864ccb1
Compare
xiaoxiang781216
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These values are board-specific properties that must be known on the application side.
Until now, these values had to be hardcoded on the application side.
Impact
we can get rid of the hardcoded ADC scaling values on the app side.
This is also the first step to support configurable phase currents gain.
Testing
odriver3.6 board (not yet upstream)