udp: Add support for SO_TIMESTAMP #11210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acassis
approved these changes
Nov 17, 2023
| /* Store reception timestamp if enabled and not provided by hardware. */ | ||
|
|
||
| #if defined(CONFIG_NET_TIMESTAMP) && !defined(CONFIG_ARCH_HAVE_NETDEV_TIMESTAMP) | ||
| clock_gettime(CLOCK_REALTIME, &dev->d_rxtime); |
There was a problem hiding this comment.
let's create a new patch to update socketcan to allow the net can driver return timestamp too
There was a problem hiding this comment.
SocketCAN does something similar here but I'm unfamiliar with CAN and have no way to test it, so I cannot help in updating it.
| */ | ||
|
|
||
| offset = (dev->d_appdata - iob->io_data) - iob->io_offset; | ||
|
|
||
| #ifdef CONFIG_NET_TIMESTAMP | ||
| /* Store timestamp while packet is being queued. | ||
| * This is done unconditionally to avoid race condition when SO_TIMESTAMP |
There was a problem hiding this comment.
should we make the similar change to can socket?
Adds support for timestamping received UDP packets, either in hardware or in kernel. Builds on the existing support of SO_TIMESTAMP for SocketCAN. Implementation uses CLOCK_REALTIME for timestamping to match the behavior of Linux. This could be made configurable in future if needed.
PetteriAimonen
force-pushed
the
dev_so_timestamp
branch
from
f2af9cf
to
9fad832
Compare
xiaoxiang781216
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for timestamping received UDP packets, either in hardware or in kernel. Builds on the existing support of
SO_TIMESTAMPfor SocketCAN.Implementation uses
CLOCK_REALTIMEfor timestamping to match the behavior of Linux. This could be made configurable in future if needed.Impact
When
CONFIG_NET_TIMESTAMPis enabled,setsockopt(..., SO_TIMESTAMP)can be used to enable timestamping.Software timestamping is supported on all platforms. This already removes any queuing latency, but threads with higher priority than network processing can delay timestamping.
Platforms where hardware support exists can define
ARCH_HAVE_NETDEV_TIMESTAMPand store the timestamp tod_rxtimebefore callingipv4_input/ipv6_input.Testing
Tested on custom STM32F4 board with a ptpd version that has SO_TIMESTAMP support. I'll submit a pull request of that to nuttx-apps once I have cleaned it up.