Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim/macos:fix system bzero recursive call #11234

Closed
wants to merge 1 commit into from

Conversation

anjiahao1
Copy link
Contributor

Summary

sim/macos:fix system bzero recursive call

Impact

noting

Testing

sim:nsh

There may be other functions where recursion occurs

Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@anjiahao1
Copy link
Contributor Author

0000000100024574 <_bzero>: /bzero       [3/19]
100024574: d10083ff     sub sp, sp, #32
100024578: a9017bfd     stp x29, x30, [sp, #16]
10002457c: f90007e0     str x0, [sp, #8]
100024580: f90003e1     str x1, [sp]
100024584: f94007e0     ldr x0, [sp, #8]
100024588: f94003e1     ldr x1, [sp]
10002458c: 97fffffa     bl  0x100024574 <_bzero>
100024590: a9417bfd     ldp x29, x30, [sp, #16]
100024594: 910083ff     add sp, sp, #32
100024598: d65f03c0     ret

This is the assembly before modification. I suspect that the bug may be caused by macos clang upgrade. @masayuki2009

@pkarashchenko
Copy link
Contributor

@xiaoxiang781216 could someone from your team take a look?

@masayuki2009
Copy link
Contributor

@anjiahao1
Could you move the commit to #11207?
Using the same PR is easy to test.

@anjiahao1
Copy link
Contributor Author

@anjiahao1 Could you move the commit to #11207? Using the same PR is easy to test.

ok i move it ,and close this pr

@anjiahao1 anjiahao1 closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants