task/pthread_cancelpt: Fix nxtask_delete from another task group #11241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pussuw
changed the title
jerpelea
approved these changes
Nov 22, 2023
PR apache#11165 causes an unnecessary regression; task_delete no longer works, if the deleted task is from another group. The logic that prevents this comes from: nxnotify_cancellation() -> tls_get_info_pid() -> nxsched_get_stackinfo() Which checks for permissions, which does not make sense in this case since it is the kernel asking for the stack information. Fix this by partially reverting 11165 and implementing a direct path for the kernel to query for any tasks TLS.
pussuw
force-pushed
the
fix_cancelpt_regression
branch
from
19c9b4d
to
bc842d4
Compare
xiaoxiang781216
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #11165 causes an unnecessary regression; task_delete no longer works, if the deleted task is from another group.
The logic that prevents this comes from:
nxnotify_cancellation() ->
tls_get_info_pid() ->
nxsched_get_stackinfo()
Which checks for permissions, which does not make sense in this case since it is the kernel asking for the stack information.
Fix this by partially reverting 11165 and implementing a direct path for the kernel to query for any tasks TLS.
Impact
Fix the regression
Testing
rv-virt:nsh64 + ostest, test task_delete