New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sh:Enhanced compilation system #11303
Conversation
In this change, if board/include and board/script are not found, they will be looked for again in the upper level of common. Signed-off-by: chenrun1 <chenrun1@xiaomi.com>
@crafcat7 did you compare the build time before and after this modification? |
I'm not so sure my method of comparison is accurate the way I do it:
The resulting data is as follows: Meanwhile, considering that there might be some calculation error when running, I tried it several times, and it's around +- 1s. |
…ents Avoid splicing paths to /include when BOARD_COMMON_DIR does not exist and enhanced Windows native compilation Signed-off-by: chenrun1 <chenrun1@xiaomi.com>
I have encountered a problem. I tried to go and compile Native’s NuttX in my local Windows environment before making the changes, but it looks like there are some issues, so I can’t verify that the commits are correct after the changes.
|
let's keep the code sync between Windows and Linux, the native Windows build need more work. |
Summary
While simplifying some of the Simulator-based configurations, I found one area that could be improved - I added an extra layer to retrieve paths at compile time.
This means that we can extract the script and include paths to the common directory, and in common we only need to store some private files for configuration.
Impact
Added a layer of path searching, now common is placed in a flat directory with board, if there is no include / script stored in the board directory, then it will look in common.
Testing
Based on this change, the local board path accomplishes the desired goal and does not affect configurations such as sim:nsh