video/vnc: add vnc_fb_register #11383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianglianfang
force-pushed
the
feat_vnc
branch
2 times, most recently
from
6431102
to
ee7e307
Compare
|
I successfully compiled sim:vncserver in the docker [ https://github.com/apache/nuttx/pkgs/container/nuttx%2Fapache-nuttx-ci-linux],
|
|
I guess the error is due to linker doesn't move the unused fb_register from final image. It could be fixed by changing fb_register to macro or inline function. |
jianglianfang
force-pushed
the
feat_vnc
branch
2 times, most recently
from
2ec34bb
to
bda2d2a
Compare
|
@jianglianfang before we merge it, could you please confirm that this tutorial still working after your modifications: https://nuttx.apache.org/docs/latest/platforms/sim/sim/index.html#running-vnc-server ? |
jianglianfang
force-pushed
the
feat_vnc
branch
5 times, most recently
from
1030d76
to
70ed1d2
Compare
jianglianfang
force-pushed
the
feat_vnc
branch
2 times, most recently
from
a79c11a
to
37698bd
Compare
|
Could you please verify the compilation error? |
jianglianfang
force-pushed
the
feat_vnc
branch
2 times, most recently
from
bc79173
to
53cbb2c
Compare
To optimize the initialization of vnc, change it to vnc_fb_register. Signed-off-by: jianglianfang <jianglianfang@xiaomi.com>
xiaoxiang781216
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimize the initialization of vnc, change it to vnc_fb_register.
Impact
Nuttx vnc
Testing
run nuttx with vnc