net/netdev: Modify the logic for setting the IFF_RUNNING status of interfaces. #11396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchao
reviewed
Dec 14, 2023
liqinhuixm
force-pushed
the
br_ifflag_carrier_set
branch
from
c7ad3ca
to
7990cf5
Compare
…terfaces. Refer to the logic of the `netif_carrier_on` on linux. https://github.com/torvalds/linux/blob/master/net/sched/sch_generic.c#L575 Signed-off-by: liqinhui <liqinhui@xiaomi.com>
liqinhuixm
force-pushed
the
br_ifflag_carrier_set
branch
from
7990cf5
to
f934591
Compare
xiaoxiang781216
approved these changes
Dec 15, 2023
| struct wlan_priv_s *priv = &g_wlan_priv[ESP32S3_WLAN_STA_DEVNO]; | ||
|
|
||
| if (priv != NULL) | ||
| if (linkstatus == true) |
There was a problem hiding this comment.
why remov the null check?
There was a problem hiding this comment.
The priv cann't be NULL. Becasue the g_wlan_priv is an array of struct wlan_priv_s.
| struct wlan_priv_s *priv = &g_wlan_priv[ESP32C3_WLAN_STA_DEVNO]; | ||
|
|
||
| if (priv != NULL) |
xiaoxiang781216
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modify the logic for setting the IFF_RUNNING status of interfaces.
Refer to the logic of the
netif_carrier_onon linux.https://github.com/torvalds/linux/blob/master/net/sched/sch_generic.c#L575
Impact
N/A
Testing
When we set the
eth0interface with the commandsifup eth0（orifdown eth0）continuously on emulator.And no error is returned.