Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring up changes from nuttx/pci branch #11570

Closed
wants to merge 4 commits into from

Conversation

raiden00pl
Copy link
Contributor

Summary

This is work from nuttx pci branch from @sonicyang with my cosmetic changes and squashing related commits.
I'll start working on PCIE soon and these commits will be the basis for my work.
This PR doesn't contain 9a36544 because I'll rewrite it as common logic for Intel64

Impact

Testing

CI

@btashton
Copy link
Contributor

Looks like my changes may have gotten dropped? I made quite a few fixes around the PCI stuff to the point were I was able to use it on my laptop and enumerate real devices. Let me see if I can find this.

@btashton
Copy link
Contributor

btashton commented Jan 20, 2024

Here it is https://github.com/btashton/incubator-nuttx/commits/pci-btashton/
It contains quite a bit of code on top of what is here that is both bug fixes and implementation extensions.

@acassis
Copy link
Contributor

acassis commented Jan 20, 2024

@btashton is it possible to send the improvements you made on top of this commit? It should be very useful case we could get NuttX booting on real x84_64 with PCIe support!

@btashton
Copy link
Contributor

I don't think this branch in the PR is ready to merge given the issues that were resolved. Why not pull these changes in?

@xiaoxiang781216
Copy link
Contributor

@raiden00pl we are developing a pcie driver framework, which may better than this one.

@raiden00pl
Copy link
Contributor Author

raiden00pl commented Jan 21, 2024

Looks like my changes may have gotten dropped? I made quite a few fixes around the PCI stuff to the point were I was able to use it on my laptop and enumerate real devices. Let me see if I can find this.

THB, this is the first time I see your https://github.com/btashton/incubator-nuttx/commits/pci-btashton/ branch and these commits where not included on nuttx/pci branch. I'll be happy to include these changes.

@raiden00pl we are developing a pcie driver framework, which may better than this one.

@xiaoxiang781216 do you have any plans to add this to the upstream in the near future?

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Jan 21, 2024

Yes, it will upstream once it's mature in the next couple month.

@raiden00pl
Copy link
Contributor Author

@xiaoxiang781216 what do you think about applying this pcie implementation first (with the changes from Brennan included). When your implementation goes upstream we can mark this work as legacy, port what is needed to the new version and when everything is ported, remove the legacy version.

@xiaoxiang781216
Copy link
Contributor

Sure.

@raiden00pl raiden00pl closed this Jan 25, 2024
@raiden00pl raiden00pl deleted the pci_master branch February 26, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants