rpmsg/rpmsg_ping: fix CI check issues #11675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpmsg_ping.c is blocking CI checks for RPTUN related patches like apache#11673. this patch simply fix the compilation issue of rpmsg_ping.c: - line 191: overflow conversion from "long unsigned int" to "unsigned int" - line 226: "sendlen" used uninitialized Signed-off-by: Yanfeng Liu <yfliu2008@qq.com>
yf13
changed the title
acassis
approved these changes
Feb 8, 2024
jerpelea
approved these changes
Feb 8, 2024
| @@ -188,11 +188,11 @@ static void rpmsg_ping_logout_rate(uint64_t len, clock_t avg) | |||
| int rpmsg_ping(FAR struct rpmsg_endpoint *ept, | |||
| FAR const struct rpmsg_ping_s *ping) | |||
| { | |||
| clock_t min = ULONG_MAX; | |||
| clock_t min = UINT_MAX; | |||
There was a problem hiding this comment.
@yf13 it's better to change to CLOCK_MAX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rpmsg_ping.c is blocking CI checks for RPTUN related patches like #11673. this patch simply fix the compilation issue of rpmsg_ping.c:
Impact
Ths is to unblock RPTUN/RPMSG related pull requests
Testing
build check