build/cmake: fix empty BASE_DEFCONFIG #11788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchao
reviewed
Feb 27, 2024
yf13
force-pushed
the
cmake-base-defconfig
branch
2 times, most recently
from
69668c1
to
3e79e13
Compare
yf13
force-pushed
the
cmake-base-defconfig
branch
from
3e79e13
to
00b5ad8
Compare
yf13
changed the title
Currently CMake system has empty string for BASE_DEFCONFIG option. This patch fills value for it. Signed-off-by: Yanfeng Liu <yfliu2008@qq.com>
yf13
force-pushed
the
cmake-base-defconfig
branch
from
00b5ad8
to
5137a44
Compare
xiaoxiang781216
approved these changes
Feb 28, 2024
jerpelea
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current CMake build system has empty string for BASE_DEFCONFIG option. This patch fills "board/config" as value for it.
Impact
CMake
Testing
Checked with "sim/nsh"