Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/video/isx019: Fix default_value of 3A status #11994

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

SPRESENSE
Copy link
Contributor

@SPRESENSE SPRESENSE commented Mar 26, 2024

Summary

Fix default_value of ioctl(VIDIOC_QUERYCTRL)(id=V4L2_CID_3A_STATUS) to AE operating and AWB operating, because both AE and AWB are automatical adjustment mode by default.

Impact

isx019

Testing

Tested with spresense

@acassis
Copy link
Contributor

acassis commented Mar 26, 2024

Please fix these errors:

video/isx019.c: In function 'isx019_get_supported_value':
Error: video/isx019.c:1981:55: error: 'struct isx019_default_value_s' has no member named 'exptime'
1981 | STEP_EXPOSURETIME, def->exptime);
| ^~
video/isx019.c:61:38: note: in definition of macro 'SET_RANGE'
61 | (range).default_value = (def);
| ^~~
Error: video/isx019.c:2003:25: error: 'struct isx019_default_value_s' has no member named 'iso'
2003 | def->iso);
| ^~
video/isx019.c:70:37: note: in definition of macro 'SET_DISCRETE'
70 | (disc).default_value = (def);
| ^~~
make[1]: *** [Makefile:102: isx019.o] Error 1

@SPRESENSE
Copy link
Contributor Author

@acassis
The related PR #11999 is merged.
So, this build break must be fixed.
No need to change anything.
Please confirm it.

@xiaoxiang781216
Copy link
Contributor

@acassis The related PR #11999 is merged. So, this build break must be fixed. No need to change anything. Please confirm it.

do you need update patch to fix the build break?

Fix default_value of ioctl(VIDIOC_QUERYCTRL)(id=V4L2_CID_3A_STATUS)
to AE operating and AWB operating, because both AE and AWB are
automatical adjustment mode by default.
@SPRESENSE
Copy link
Contributor Author

@acassis @xiaoxiang781216 I've rebased this PR.

@xiaoxiang781216 xiaoxiang781216 merged commit d5c6549 into apache:master Mar 29, 2024
23 of 26 checks passed
@jerpelea jerpelea added this to To-Add in Release Notes - 12.5.1 Apr 8, 2024
@jerpelea jerpelea moved this from To-Add to Not Applicable in Release Notes - 12.5.1 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants