fix: the bug about rwbuffer causing mem overflow #12056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when the offest from rwb->wrblockstart to startblock plus rwb->wrnblocks is greater than rwb->wralignblocks, it will be causing memory overflow since rwb->wrbuffer is allocated rwb.wrmaxblock(rwb.wralignblocks) block_size bytes |
|
@ChenChuangForLinux please check coding style issues: $ ./tools/checkpatch.sh -f drivers/misc/rwbuffer.c And fix the issues |
|
@ChenChuangForLinux please squash into one patch. |
ChenChuangForLinux
force-pushed
the
master
branch
from
7cb909b
to
86e4741
Compare
acassis
reviewed
Apr 6, 2024
ChenChuangForLinux
force-pushed
the
master
branch
3 times, most recently
from
10ee259
to
e6b378e
Compare
drivers/misc/rwbuffer.c
Outdated
| { | ||
| tmp_blocks = padblocks - rwb->wrnblocks - | ||
| rwb->wralignblocks; | ||
| tmp = kmm_malloc(tmp_blocks * rwb->blocksize); |
There was a problem hiding this comment.
it isn't good to allocate temp buffer in the hot path.
|
@ChenChuangForLinux please remove the merge patch from pr. |
ChenChuangForLinux
force-pushed
the
master
branch
from
2faa889
to
46b1eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the offest from rwb->wrblockstart to startblock plus rwb->wrnblocks is greater than rwb->wralignblocks, it will be causing memory overflow since rwb->wrbuffer is allocated rwb.wrmaxblock(rwb.wralignblocks) bytes.
Summary
Impact
Testing