arch/arm64/src/imx9/imx9_flexio_pwm.c: Fix wrong input scale #12059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaitine
force-pushed
the
imx9_flexio_pwm_fix_scale
branch
from
e9392b1
to
0c9558b
Compare
acassis
approved these changes
Apr 5, 2024
jlaitine
force-pushed
the
imx9_flexio_pwm_fix_scale
branch
from
0c9558b
to
f6a428d
Compare
|
For now, just re-based to pass the CI, which had problems yesterday. I can update to ub16 macros next week if needed, but I don't like those macros for several reasons (mainly because they hide the math behind incomprehensible macros). |
jlaitine
force-pushed
the
imx9_flexio_pwm_fix_scale
branch
from
f6a428d
to
0da4752
Compare
…e width Signed-off-by: Jukka Laitinen <jukkax@ssrc.tii.ae>
jlaitine
force-pushed
the
imx9_flexio_pwm_fix_scale
branch
from
0da4752
to
1e7a460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This error was left in the original PR, I messed up with re-basing patches accross branches. The duty cycle is a 16.16 fixed point integer (ub16) between 0-1.
Impact
Testing
Tested with logic analyzer & i.MX93EVK board.