sched/pthread: detached thread should destroy the join info #12106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to ensure the detached thread obtain the correct return value from pthread_join()/pthread_cancel(), the detached thread will create joininfo to save the detached status after thread destroyed. If there are too many of detached threads in the process group, the joininfo will consume too much memory. This is not friendly to embedded MCU devices. This commit keep the semantics as apache#11898 was introduced, will no longer save joininfo for detached threads to avoid wasting memory. Signed-off-by: chao an <anchao@lixiang.com>
xiaoxiang781216
approved these changes
Apr 9, 2024
pkarashchenko
approved these changes
Apr 9, 2024
anchao
added a commit
to anchao/nuttx-apps
that referenced
this pull request
Apr 9, 2024
…uld return EINVAL, not ESRCH" This reverts commit 69e497f. In order to ensure the detached thread obtain the correct return value from pthread_join()/pthread_cancel(), the detached thread will create joininfo to save the detached status after thread destroyed. If there are too many of detached threads in the process group, the joininfo will consume too much memory. This is not friendly to embedded MCU devices. This commit keep the semantics as #11898 was introduced, will no longer save joininfo for detached threads to avoid wasting memory. Refer PR: apache/nuttx#12106 Signed-off-by: chao an <anchao@lixiang.com>
|
Depends on apache/nuttx-apps#2353 |
xiaoxiang781216
pushed a commit
to apache/nuttx-apps
that referenced
this pull request
Apr 9, 2024
…uld return EINVAL, not ESRCH" This reverts commit 69e497f. In order to ensure the detached thread obtain the correct return value from pthread_join()/pthread_cancel(), the detached thread will create joininfo to save the detached status after thread destroyed. If there are too many of detached threads in the process group, the joininfo will consume too much memory. This is not friendly to embedded MCU devices. This commit keep the semantics as #11898 was introduced, will no longer save joininfo for detached threads to avoid wasting memory. Refer PR: apache/nuttx#12106 Signed-off-by: chao an <anchao@lixiang.com>
xiaoxiang781216
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sched/pthread: detached thread should destroy the join info
In order to ensure the detached thread obtain the correct return value from pthread_join()/pthread_cancel(), the detached thread will create joininfo to save the detached status after thread destroyed. If there are too many of detached threads in the process group, the joininfo will consume too much memory. This is not friendly to embedded MCU devices.
This commit keep the semantics as #11898 was introduced, will no longer save joininfo for detached threads to avoid wasting memory.
Impact
Fix issue #12096
Testing
ostest / ci-check