Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64/imx9: Add LPI2C driver #12149

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

pussuw
Copy link
Contributor

@pussuw pussuw commented Apr 15, 2024

Summary

Adds LPI2C driver (fork-lifted from IMXRT) for IMX93

Impact

Add new driver for IMX93. Both polling and DMA modes work, but eDMA driver will be added later!

Testing

imx93-evk

@acassis
Copy link
Contributor

acassis commented Apr 15, 2024

Maybe you need to include the right header:

Error: chip/imx9_lpi2c.c:758:3: error: implicit declaration of function 'modifyreg32'; did you mean 'modreg32'? [-Werror=implicit-function-declaration]
  758 |   modifyreg32(priv->config->base + offset, clearbits, setbits);

@pussuw
Copy link
Contributor Author

pussuw commented Apr 15, 2024

Maybe you need to include the right header:

Error: chip/imx9_lpi2c.c:758:3: error: implicit declaration of function 'modifyreg32'; did you mean 'modreg32'? [-Werror=implicit-function-declaration]
  758 |   modifyreg32(priv->config->base + offset, clearbits, setbits);

Need to rebase, it's missing this: #12146

@pussuw
Copy link
Contributor Author

pussuw commented Apr 16, 2024

Rebase is now done @acassis :)

Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add commit message describing the change

@xiaoxiang781216 xiaoxiang781216 merged commit f8c5b91 into apache:master Apr 16, 2024
26 checks passed
@pussuw pussuw deleted the imx9_lpi2c branch April 16, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants