Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/Toolchain.defs: Change all ARCROSSDEV to CROSSDEV #1439

Merged
merged 1 commit into from Jul 21, 2020

Conversation

xiaoxiang781216
Copy link
Contributor

Summary

ARCROSSDEV always equals to CROSSDEV, so it is no reason to keep ARCROSSDEV.

Impact

No visible change.

Testing

ARCROSSDEV always equals to CROSSDEV, so it is no reason to keep ARCROSSDEV.

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 linked an issue Jul 21, 2020 that may be closed by this pull request
@btashton
Copy link
Contributor

Why not just define ARCROSSDEV for the three architectures that are missing it? If we do remove it, than we should also remove the definitions of it.

It is missing from from mips32 avr32 avr mor1kx

@xiaoxiang781216
Copy link
Contributor Author

xiaoxiang781216 commented Jul 21, 2020

Why not just define ARCROSSDEV for the three architectures that are missing it? If we do remove it, than we should also remove the definitions of it.

It is missing from from mips32 avr32 avr mor1kx

I remove ARCROSSDEV because it is always same as CROSSDEV, which could also simplify user setup, but I can add ARCROSSDEV for mips32 avr32 avr mor1kx if you prefer.

@btashton
Copy link
Contributor

I did not see where you removed the ARCROSSDEV for arm in the diff UI, but I see it now. Sorry for the confusion.
I think this is probably safe, I cannot think of a good reason for using a different binutils than the one that would have come with the rest of the cross toolchain.

@btashton btashton merged commit 5efa93e into apache:master Jul 21, 2020
@xiaoxiang781216 xiaoxiang781216 deleted the build2 branch July 21, 2020 08:45
@btashton btashton added this to To-Add in Release Notes - 10.0.0 Oct 14, 2020
@Ouss4 Ouss4 moved this from To-Add to In Progress in Release Notes - 10.0.0 Oct 18, 2020
@Ouss4 Ouss4 moved this from In Progress to Added in Release Notes - 10.0.0 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

AVR builds now failing in macOS
2 participants