libc: Add uuid implemenation #1440
Conversation
xiaoxiang781216
force-pushed
the
uuid
branch
2 times, most recently
from
b3fa764
to
076f2a0
Compare
|
|
||
| /* The UUID string representation has a fixed length. */ | ||
|
|
||
| if (strlen(s) != UUID_STR_LEN) |
There was a problem hiding this comment.
Should we protect this with strnlen(s, UUID_STR_LEN+1)
| #include <endian.h> | ||
| #include <uuid.h> | ||
|
|
||
| /**************************************************************************** |
There was a problem hiding this comment.
Did this code come from NetBSD? It looks a lot like the code here
http://mirrors.mit.edu/NetBSD/NetBSD-release-7/src/lib/libc/uuid/uuid_stream.c
If so my understanding is that we would leave the BSD headers on this and call it out in the LICENSE file
There was a problem hiding this comment.
The code is rewritten from scratch now. Should we put some note in LICENSE file?
There was a problem hiding this comment.
I think this is fine now. Most of these functions are trivial especially with us using our existing endian code.
libs/libc/uuid/lib_uuid_stream.c
Outdated
|
|
||
| /* Alignment-agnostic encode/decode bytestream to/from little/big endian. */ | ||
|
|
||
| static inline uint16_t be16dec(const void *pp) |
There was a problem hiding this comment.
These endian functions dont seem to be uuid specific. Normally they are defined via <machine/endian.h> or <endian.h> OS specific location.
specified by OpenGroup here: https://pubs.opengroup.org/onlinepubs/009629399/toc.htm Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I3bc585e7f4d41f6c2ea70e170276ab0d0399b088
Summary
Adds the UUID libc functions specified by OpenGroup here:
https://pubs.opengroup.org/onlinepubs/009629399/toc.htm
Impact
Testing