USB: Do not try to print NULL format strings for verbose trace messages when disabled #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if usb tracing is enabled but verbose is disabled a debug assert will be triggered when ever a verbose trace point is hit. Instead of trying to print the NULL message, just return early. Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
xiaoxiang781216
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now if usb tracing is enabled but verbose is disabled a debug assert will be triggered when ever a verbose trace point is hit because the return format pointer would be NULL (by design). Instead of trying to print the NULL message, just return early. This does not change any normal functionality.
Impact
USB tracing can be enabled in non-verbose mode with debug asserts on.
Testing
nucleo-h745iz:otg_fs_host with debug asserts enabled and trace on. Prior this change it would hit the assert right away.