Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkrelease script to check readme.md instead of .txt #2404

Merged
merged 1 commit into from Nov 26, 2020

Conversation

btashton
Copy link
Contributor

Summary

When the readme was converted to markdown the extension to look for in in the release verification script was not updated and would fail like this:

Checking apache-nuttx-10.0.0-incubating.tar.gz for required files:
 - README.txt file not present.

This corrects the filename.

Impact

The release checking script now passes.

Testing

Here it is running against the latest staged RC

❯ ./tools/checkrelease.sh --release 10.0.0-RC0
<<TRIM>>
Checking apache-nuttx-10.0.0-incubating.tar.gz sha512...
 OK: apache-nuttx-10.0.0-incubating.tar.gz sha512 hash matches.

Checking apache-nuttx-10.0.0-incubating.tar.gz GPG signature:
<<TRIM>>
Primary key fingerprint: 3554 D784 58CE B695 4B02  0E12 E1B6 E30D B05D 6280
     Subkey fingerprint: 66C4 832A 165E CC93 5489  5A20 9750 ED7E 692B 99E2
 OK: apache-nuttx-10.0.0-incubating.tar.gz gpg signature matches.

Checking apache-nuttx-10.0.0-incubating.tar.gz for required files:
 OK: all required files exist in nuttx.

Checking apache-nuttx-apps-10.0.0-incubating.tar.gz sha512...
 OK: apache-nuttx-apps-10.0.0-incubating.tar.gz sha512 hash matches.

Checking apache-nuttx-apps-10.0.0-incubating.tar.gz GPG signature:
<<TRIM>>
 OK: apache-nuttx-apps-10.0.0-incubating.tar.gz gpg signature matches.

Checking apache-nuttx-apps-10.0.0-incubating.tar.gz for required files:
 OK: all required files exist in apps.

Trying to build nuttx sim:nsh...
 OK: we were able to build sim:nsh.

Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
@btashton btashton changed the title Update checkrelease script for readme.md inread of .txt Update checkrelease script for readme.md instead of .txt Nov 26, 2020
@btashton btashton changed the title Update checkrelease script for readme.md instead of .txt Update checkrelease script to check readme.md instead of .txt Nov 26, 2020
@Ouss4
Copy link
Member

Ouss4 commented Nov 26, 2020

Do you plan to backport this one? I don't think we should cancel the current RC for a change in tools/.

@xiaoxiang781216 xiaoxiang781216 merged commit b021375 into master Nov 26, 2020
@btashton
Copy link
Contributor Author

Do you plan to backport this one? I don't think we should cancel the current RC for a change in tools/.

I was not planning on it, if we do a RC1 we can backport it in.

@Ouss4 Ouss4 deleted the checkrelease branch November 26, 2020 17:04
@btashton btashton added this to To-Add in Release Notes - 10.1.0 Apr 12, 2021
@jerpelea jerpelea moved this from To-Add to Minor in Release Notes - 10.1.0 Apr 12, 2021
@jerpelea jerpelea moved this from Minor to Added in Release Notes - 10.1.0 Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants