Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched: pthread: Fix potential bugs in pthread_condclockwait.c #2538

Merged
merged 1 commit into from Dec 15, 2020

Conversation

masayuki2009
Copy link
Contributor

@masayuki2009 masayuki2009 commented Dec 15, 2020

Summary

  • I found potential bugs in pthread_condclockwait.c
  • Actually, sched_unlock() and wd_cancel() were misplaced.
  • This commit fixes this issue

Impact

  • pthread_cond_clockwait() only

Testing

  • Tested with ostest with the following configs
  • sabre-6quad:nsh, sabre-6quad:smp, sim:ostest

Summary:
- I found potential bugs in pthread_condclockwait.c
- Actually, sched_unlock() and wd_cancel() were misplaced.
- This commit fixes this issue

Impact:
- pthread_cond_clockwait() only

Testing:
- Tested with ostest with the following configs
- sabre-6quad:nsh, sabre-6quad:smp, sim:ostest

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xiaoxiang781216 xiaoxiang781216 merged commit 8ba67b7 into apache:master Dec 15, 2020
@masayuki2009 masayuki2009 deleted the fix_pthread branch January 28, 2021 23:10
@btashton btashton added this to To-Add in Release Notes - 10.1.0 Apr 12, 2021
@jerpelea jerpelea moved this from To-Add to Minor in Release Notes - 10.1.0 Apr 12, 2021
@jerpelea jerpelea moved this from Minor to Added in Release Notes - 10.1.0 Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants