fs: Fix the race condition in file_dup #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
force-pushed
the
file_dup
branch
from
b1da811
to
ced1258
Compare
…p1 succeed Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I10956f5e32cc0add414076465c06a24a858e52bc
NULL inode passed to files_allocate doesn't mark file struct in the allocated state, so other threads which invovle in file allocation (e.g. open or dup) may allocate the same file struct again. Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I53ff876eae3c7a1e311e7f671686b73a4b4ef891
xiaoxiang781216
force-pushed
the
file_dup
branch
from
ced1258
to
97c0dfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NULL inode passed to files_allocate doesn't mark file struct in the allocated state, so other threads which invovle in file allocation(e.g. open or dup) may allocate the same file struct again.
Let's use a temp file struct to avoid the NULL inode case.
Impact
Fix the race condition
Testing