boards/raspberrypi-pico: Pico Display Pack (ST7789 LCD) support #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunkya2
force-pushed
the
rppico-display-pack
branch
from
e14d42e
to
81b6bb1
Compare
xiaoxiang781216
approved these changes
Mar 15, 2021
acassis
requested changes
Mar 15, 2021
|
|
||
| int board_lcd_initialize(void) | ||
| { | ||
| g_spidev = rp2040_spibus_initialize(LCD_SPI_PORTNO); |
There was a problem hiding this comment.
LCD_SPI_PORTNO shouldn't be hardcoded, pass it as a function parameter!
There was a problem hiding this comment.
Thanks for comment. There are some reasons for it.
- board_lcd_initialize() is common function called from lcd_framebuffer.c and it is not designed to pass a parameter. Another existing lcd support code also takes similar way.
- The "Pico Display Pack" designed for Raspberry Pi Pico has fixed pin layout. It can use only SPI ch 0.
There was a problem hiding this comment.
Thanks for comment. There are some reasons for it.
* board_lcd_initialize() is common function called from lcd_framebuffer.c and it is not designed to pass a parameter. Another existing lcd support code also takes similar way. * The "Pico Display Pack" designed for Raspberry Pi Pico has fixed pin layout. It can use only SPI ch 0.
Ah ok! Thank you for this explanation!
acassis
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
ST7789 driver and Raspberry Pi Pico
Testing
Tested with config
raspberrypi-pico:displaypack