esp32-c3: Add support to RNG peripheral #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saramonteiro
reviewed
Apr 1, 2021
Comment on lines
127
to
129
| /**************************************************************************** | ||
| * Name: esp32c3_rng_open | ||
| ****************************************************************************/ |
There was a problem hiding this comment.
Suggested change
| /**************************************************************************** | |
| * Name: esp32c3_rng_open | |
| ****************************************************************************/ |
Ouss4
reviewed
Apr 1, 2021
| static pthread_once_t once_control = PTHREAD_ONCE_INIT; | ||
| int ret; | ||
|
|
||
| ret = pthread_once(&once_control, esp32c3_rng_initialize); |
There was a problem hiding this comment.
Yes, I think you are right. Probably this check to avoid running xxxx_rng_initialize() twice was added to arch/arm/src/nrf52/nrf52_rng.c because because someone thought it could be called from devrandom_register() and devurandom_register() during the boot, but the #ifndef is protecting it. I'll remove it!
gustavonihei
reviewed
Apr 1, 2021
Co-authored-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com> Co-authored-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>
|
@xiaoxiang781216 / @Ouss4 please merge it |
xiaoxiang781216
approved these changes
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to RNG peripheral
Impact
Only ESP32-C3
Testing
ESP32C3-Devkitc