Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risc-v/esp32c3: Support ESP32-C3 efuse #3881

Merged
merged 1 commit into from Jun 16, 2021

Conversation

lhespress
Copy link
Contributor

@lhespress lhespress commented Jun 9, 2021

Summary

risc-v/esp32c3: Support ESP32-C3 efuse Driver

Impact

Testing

The efuse driver was successfully tested in esp32c3-devkitc using the efuse example.

  • config

    ./tools/configure esp32c3-devkit:efuse

  • test result

    efuse

@gustavonihei
Copy link
Contributor

@lhespress Please, use the PR description template.

@lhespress
Copy link
Contributor Author

lhespress commented Jun 10, 2021

Thanks, I have modified it.

@gustavonihei
Copy link
Contributor

gustavonihei commented Jun 11, 2021

@lhespress The CI is complaining that the efuse defconfig is not refreshed.
Please, run ./tools/refresh.sh --silent esp32c3-devkit:efuse to fix it.

@lhespress lhespress force-pushed the feature/esp32c3_efuse branch 2 times, most recently from abf263b to 7909355 Compare June 15, 2021 07:52
Comment on lines 238 to 240
goto errout;
}

errout:
return ret;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goto errout;
}
errout:
return ret;
}
return ret;

No need for this goto.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have modified it.

* Input Parameters:
* lower - A pointer the publicly visible representation of
* the "lower-half" driver state structure
* cmd - The ioctol command value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* cmd - The ioctol command value
* cmd - The ioctl command value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have modified it.

} esp_efuse_block_t;

/****************************************************************************
* Name: efuse_func_proc_t;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Name: efuse_func_proc_t;
* Name: efuse_func_proc_t

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have modified it.

****************************************************************************/

/****************************************************************************
* Name: esp32c3_efuse_read_field;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Name: esp32c3_efuse_read_field;
* Name: esp32c3_efuse_read_field

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have modified it.

size_t dst_size_bits);

/****************************************************************************
* Name: esp32c3_efuse_write_field;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Name: esp32c3_efuse_write_field;
* Name: esp32c3_efuse_write_field

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have modified it.

const void *src, size_t src_size_bits);

/****************************************************************************
* Name: esp32c3_efuse_burn_efuses;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Name: esp32c3_efuse_burn_efuses;
* Name: esp32c3_efuse_burn_efuses

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have modified it.

void esp32c3_efuse_burn_efuses(void);

/****************************************************************************
* Name: esp32c3_efuse_initialize;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Name: esp32c3_efuse_initialize;
* Name: esp32c3_efuse_initialize

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have modified it.

@gustavonihei gustavonihei merged commit 04c8052 into apache:master Jun 16, 2021
@Ouss4 Ouss4 added this to To-Add in Release Notes - 10.2 Oct 11, 2021
@jerpelea jerpelea moved this from To-Add to new support in Release Notes - 10.2 Oct 13, 2021
@jerpelea jerpelea moved this from new support to Added in Release Notes - 10.2 Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants