Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs/libxx/uClibc++.defs: Download the correct file type. #4368

Merged
merged 1 commit into from Aug 18, 2021

Conversation

Ouss4
Copy link
Member

@Ouss4 Ouss4 commented Aug 18, 2021

Summary

The archive type has changed apparently.

Impact

Fix current build breakage.

Testing

sim:cxxtest

Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>
@Ouss4
Copy link
Member Author

Ouss4 commented Aug 18, 2021

@xiaoxiang781216 this should fix the current CI error. But I don't know what happened to the previous file location, I can't find it in uClib++ website.

@Ouss4
Copy link
Member Author

Ouss4 commented Aug 18, 2021

@xiaoxiang781216 BTW is there any reason why C++ libraries are downloaded during dirlinks instead of the usual in context?

dirlinks is also part of context, however it's also in the way of olddefconfig which ./configure.sh does at the end. So we are downloading C++ libraries when configuring. I have a commit to move that to context, I'll push it if there is no issue (it will be with a separate PR though, let's get this one merged so we unblock the CI.)

@xiaoxiang781216 xiaoxiang781216 merged commit 0ac0276 into apache:master Aug 18, 2021
@Ouss4 Ouss4 deleted the cxx branch August 18, 2021 19:48
@Ouss4 Ouss4 added this to To-Add in Release Notes - 10.2 Oct 11, 2021
@jerpelea jerpelea moved this from To-Add to fixes in Release Notes - 10.2 Oct 13, 2021
@jerpelea jerpelea moved this from fixes to Added in Release Notes - 10.2 Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants