Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: let clean_context in distclean command #4455

Merged
merged 1 commit into from Sep 2, 2021

Conversation

zhuyanlinzyl
Copy link
Contributor

In multi-jobs build, distclean may be faster than clean_context,
Fix the case distclean use the dirctorys that have been
removed by clean_context

Change-Id: I99f5c6e401289493f51b909bafd4c465e097175b

Summary

Impact

No

Testing

make clean/distclean pass on sim/arm

@Ouss4
Copy link
Member

Ouss4 commented Sep 1, 2021

What was the observed issue? Since clean_context is a prerequisite it should be executed before distclean recipe.

@zhuyanlinzyl
Copy link
Contributor Author

When run make disclean -j64 in board/xtensa with toolchain xt-xcc

Their have the case

1 clean_context run the command:

`$(Q) $(DIRUNLINK) $(ARCH_SRC)/board`

2 distclean run the command:

`make -C board distclean`

but board has be unlink by clean_context early.

@Ouss4
Copy link
Member

Ouss4 commented Sep 1, 2021

Ah I see. So the issue is between clean_context and subdir_distclean.

Please update tools/Makefile.win as well.

In multi-jobs build, `distclean` may be faster than `clean_context`,
Fix the case `distclean` use the dirctorys that have been
removed by `clean_context` in board/xtensa with xt-xcc
@xiaoxiang781216 xiaoxiang781216 merged commit 5c5975d into apache:master Sep 2, 2021
@Ouss4 Ouss4 added this to To-Add in Release Notes - 10.2 Oct 11, 2021
@jerpelea jerpelea moved this from To-Add to fixes in Release Notes - 10.2 Oct 13, 2021
@jerpelea jerpelea moved this from fixes to Added in Release Notes - 10.2 Oct 21, 2021
@zhuyanlinzyl zhuyanlinzyl deleted the makefile branch January 25, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants