New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearch video #4526
Rearch video #4526
Conversation
@SPRESENSE /github/workspace/sources/nuttx/arch/arm/src/chip/cxd56_cisif.c:1080: undefined reference to `imgdata_register' |
drivers/video/isx012.c
Outdated
@@ -34,12 +34,12 @@ | |||
#include <nuttx/fs/fs.h> | |||
#include <nuttx/i2c/i2c_master.h> | |||
#include <arch/board/board.h> | |||
#include <arch/chip/cisif.h> | |||
#include <arch/chip/cxd56_cisif.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's specific to cxd56
22d2da1
to
98ddaf7
Compare
Fixed a compile error by mpy/defconfig. |
@SPRESENSE drivers/video/isx012.c can not contain board definitions please fix it |
@jerpelea |
@SPRESENSE please fix f7cfbc1 A best practice is that each commit should compile standalone NOTE |
Rearchitect video driver: - Define two video I/F(struct imgsensor_ops_s and struct imgdata_ops_s), and support them. - CISIF driver supports new video I/F struct imgdata_ops_s. - ISX012 driver supports new video I/F struct imgsensor_ops_s. - Move ISX012 driver to general driver directory.
Add LCD and NX configurations to camera example as apps/examples/camera changes.
Add video debug macros verr/vwarn/vinfo, and replace error output macro to verr.
New CISIF which supports rearchitected video driver needs VIDEO configuration. Add VIDEO configuration because mpy defconfig includes CISIF.
98ddaf7
to
781b03a
Compare
Summary
Rearchtect video driver.
and support them.
Impact
video, isx012 on Spresense board
Testing
Tested by spresense:example_camera with apache/nuttx-apps#851