Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearch video #4526

Merged
merged 4 commits into from Sep 15, 2021
Merged

Rearch video #4526

merged 4 commits into from Sep 15, 2021

Conversation

SPRESENSE
Copy link
Contributor

Summary

Rearchtect video driver.

  • Define two video I/F(struct imgsensor_ops_s and struct imgdata_ops_s),
    and support them.
  • Move isx012 driver to general driver directory
  • Replace error output macro to verr
  • Refactor camera initialization
  • Update defconfig of camera example

Impact

video, isx012 on Spresense board

Testing

Tested by spresense:example_camera with apache/nuttx-apps#851

@jerpelea
Copy link
Contributor

@SPRESENSE /github/workspace/sources/nuttx/arch/arm/src/chip/cxd56_cisif.c:1080: undefined reference to `imgdata_register'

@jerpelea jerpelea self-requested a review September 13, 2021 06:39
@@ -34,12 +34,12 @@
#include <nuttx/fs/fs.h>
#include <nuttx/i2c/i2c_master.h>
#include <arch/board/board.h>
#include <arch/chip/cisif.h>
#include <arch/chip/cxd56_cisif.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's specific to cxd56

@SPRESENSE
Copy link
Contributor Author

@SPRESENSE /github/workspace/sources/nuttx/arch/arm/src/chip/cxd56_cisif.c:1080: undefined reference to `imgdata_register'

Fixed a compile error by mpy/defconfig.
There are still build errors, but these will be fixed by the PR apache/nuttx-apps#851.

@jerpelea
Copy link
Contributor

@SPRESENSE drivers/video/isx012.c can not contain board definitions
#include <arch/chip/cxd56_cisif.h>

please fix it

@SPRESENSE
Copy link
Contributor Author

@jerpelea
In the final code (not in the middle of commit), drivers/video/isx012.c does not include cxd56 and does not depend on cxd56. Please check it. Thanks.

@jerpelea
Copy link
Contributor

jerpelea commented Sep 14, 2021

@SPRESENSE please fix f7cfbc1
so that we have a clean build at every commit and then forcepush

A best practice is that each commit should compile standalone

NOTE
I saw that you fixed it in the next patch but the fix should not be necessary if it is fixed from the begining
f06b5ef

Rearchitect video driver:
- Define two video I/F(struct imgsensor_ops_s and struct imgdata_ops_s),
  and support them.
- CISIF driver supports new video I/F struct imgdata_ops_s.
- ISX012 driver supports new video I/F struct imgsensor_ops_s.
- Move ISX012 driver to general driver directory.
Add LCD and NX configurations to camera example as apps/examples/camera changes.
Add video debug macros verr/vwarn/vinfo, and replace error output macro to verr.
New CISIF which supports rearchitected video driver needs VIDEO configuration.
Add VIDEO configuration because mpy defconfig includes CISIF.
@jerpelea jerpelea merged commit 050ee01 into apache:master Sep 15, 2021
@Ouss4 Ouss4 added this to To-Add in Release Notes - 10.2 Oct 11, 2021
@jerpelea jerpelea moved this from To-Add to fixes in Release Notes - 10.2 Oct 13, 2021
@jerpelea jerpelea moved this from fixes to Added in Release Notes - 10.2 Oct 15, 2021
@SPRESENSE SPRESENSE deleted the rearch_video branch November 1, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants