tools/esp32: Refactor generation of QEMU-compatible image #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavonihei
force-pushed
the
feature/mergebin_qemu
branch
from
3631412
to
0753880
Compare
Use the merge_bin builtin function from esptool.py. Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
gustavonihei
force-pushed
the
feature/mergebin_qemu
branch
from
0753880
to
12a58c0
Compare
Ouss4
reviewed
Oct 19, 2021
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
gustavonihei
force-pushed
the
feature/mergebin_qemu
branch
from
12a58c0
to
2f065d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR intends to refactor the generation of the QEMU-compatible binary image for ESP32 by using the
merge_binbuiltin function fromesptool.py.The initial motivation for this is the need to provide a different
offsetfor the partition table binary, which the currentmk_qemu_img.shscript does not support.The added bonus is that this new implementation relies on
esptool.py, resulting in a cleaner implementation.Impact
Only for ESP32-based defconfigs executing on QEMU.
Testing
Validated with
esp32-devkitc:nshandesp32-devkic:spiflashexamples on QEMU.