netdev_file_ioctl: Fix fcntl F_SETFL O_NONBLOCK regression #5933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression caused by the following commit, which prevents the file flag from being updated. ``` commit 28860b5 Author: chao.an <anchao@xiaomi.com> Date: Sat Mar 19 14:47:37 2022 +0800 net/netdev: fix switch case missing break Signed-off-by: chao.an <anchao@xiaomi.com> ``` Note: some applications like mbedtls uses F_GETFL to confirm the nonblock-ness of the socket. This is critical for such applications.
xiaoxiang781216
approved these changes
Apr 1, 2022
pkarashchenko
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a regression caused by the following commit,
which prevents the file flag from being updated.
Note: some applications like mbedtls uses F_GETFL to confirm
the nonblock-ness of the socket. This is critical for such
applications.
Impact
Testing
tested with my app using mbedtls on sim/linux.