net_if: add IFF_LOOPBACK/POINTOPOINT/MULTICAST/BROADCAST #6543
Conversation
|
Please include the right summary and remove these comments: |
|
Please fix checkpatch error: "Remove Gerrit Change-ID's before submitting upstream" Thanks! |
Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
| #define IFF_MULTICAST (1 << 12) /* Supports multicast. */ | ||
| #define IFF_BROADCAST (1 << 13) /* Broadcast address valid. */ |
There was a problem hiding this comment.
Just a question: why 12 and 13 bits are used and not 8 and 9?
There was a problem hiding this comment.
This is still not answered.
There was a problem hiding this comment.
Just a question: why 12 and 13 bits are used and not 8 and 9?
I was just reusing the Linux definition, do I need to change it to bit 8 and 9?
There was a problem hiding this comment.
This is still not answered.
Sorry for my reply are not timely.
There was a problem hiding this comment.
Hello @zhhyu7
Sorry for my delay. I was away for a couple of days. The PR looks good. I will merge it now. If there is ever a need to change the bit values, they can always be changed.
|
@hartmannathan please review and merge if you are ok. |
| #define IFF_MULTICAST (1 << 12) /* Supports multicast. */ | ||
| #define IFF_BROADCAST (1 << 13) /* Broadcast address valid. */ |
There was a problem hiding this comment.
Hello @zhhyu7
Sorry for my delay. I was away for a couple of days. The PR looks good. I will merge it now. If there is ever a need to change the bit values, they can always be changed.
VELAPLATFO-2660
Signed-off-by: zhanghongyu zhanghongyu@xiaomi.com
Change-Id: Ieb6b1eadefa8e2a60832346f71fff23c85d2d88a
Summary
Impact
Testing