ESP32-C3: General improvements to Protected Mode infra #6600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After apache#6400 the prebuilt bootloader may be used for loading the NuttX images when BUILD_PROTECTED is enabled. Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
cache_dbus_mmu_set and cache_ibus_mmu_set return positive values in case of errors, so DEBUVERIFY could never detect them since this macro checks for negative values. Besides, the successful execution of those functions is mandatory for the reliable operation under Protected Mode, so the verification is always performed, even when DEBUG is not enabled. Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
xiaoxiang781216
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR intends to bring some small but relevant improvements to running NuttX in Protected Mode on platforms based on ESP32-C3 chips.
Impact
ESP32-C3 only.
Testing
esp32c3-devkit:knshsuccessful execution ofostest.