arch/sim: fix MTU mismatch on TAP device in host route mode #7380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In host route mode (bridge mode disabled), the d_pktsize of TAP device is not initialized and will be set to CONFIG_NET_ETH_PKTSIZE in netdev_register, while the MTU on host side keeps at 1500. Input packets larger than CONFIG_NET_ETH_PKTSIZE will be dropped because 'IP packet shorter than length in IP header'. This patch fix this issue by reading MTU from host side and set as d_pktsize, just the same as what is done in bridge mode. Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
xiaoxiang781216
approved these changes
Oct 21, 2022
pkarashchenko
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In host route mode (bridge mode disabled), the
d_pktsizeof TAP device is not initialized and will be set toCONFIG_NET_ETH_PKTSIZEinnetdev_register, while the MTU on host side keeps at 1500. Input packets larger thanCONFIG_NET_ETH_PKTSIZEwill be dropped because 'IP packet shorter than length in IP header'.This patch fix this issue by reading MTU from host side and set as
d_pktsize, just the same as what is done in bridge mode.Impact
Netdriver in sim.
Testing
Tested on Ubuntu 22.04 x86_64, with actual HTTP stream.