mpfs_head.S: Mark .start section attributes explicitly #7606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a = allocated, x = executable. Otherwise the input section type will become empty, which means output section will be empty as well.
xiaoxiang781216
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a = allocated, x = executable. Otherwise the input section type will become empty, which means output section will be empty as well.
Summary
Fixes issue when linking out-of-tree project with __start symbol from mpfs_head/shead.S
Impact
MPFS only
Testing
icicle:knsh and out-of-tree project that uses NuttX /w MPFS target