libc/stream:add putc interface for mtd/blk stream. #7715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 田昕 <tianxin7@xiaomi.com>
xiaoxiang781216
approved these changes
Nov 28, 2022
pkarashchenko
approved these changes
Nov 28, 2022
| @@ -217,6 +227,7 @@ int lib_blkoutstream_open(FAR struct lib_blkoutstream_s *stream, | |||
| } | |||
|
|
|||
| stream->inode = inode; | |||
| stream->public.put = blkoutstream_putc; | |||
There was a problem hiding this comment.
@xiaoxiang781216 maybe stream method also should be putc? What do you think? I've seen that recently you done some clean-up and changes from putc to put, but do not know the reasons why we stay with put now
There was a problem hiding this comment.
It's little bit inconsistent in the original code base:
- The user see the function as lib_stream_put or lib_outstream_s::put
- The implementation normally name xxx_putc as statical function
Do you think we should make the user and implementor consistent with each other?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 田昕 tianxin7@xiaomi.com
Summary
add putc interface for mtd/blk stream
Impact
Should be none.
Testing
ESP32C3 tested.