New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor change for video framebuff #7776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
force-pushed
the
camera2
branch
3 times, most recently
from
December 4, 2022 16:39
d983e78
to
818263e
Compare
xiaoxiang781216
force-pushed
the
camera2
branch
from
December 5, 2022 11:54
1708a68
to
656467f
Compare
pkarashchenko
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
xiaoxiang781216
force-pushed
the
camera2
branch
2 times, most recently
from
December 6, 2022 17:36
c6b74f1
to
7716f1a
Compare
xiaoxiang781216
force-pushed
the
camera2
branch
from
December 7, 2022 02:41
7716f1a
to
c072a05
Compare
xiaoxiang781216
force-pushed
the
camera2
branch
from
December 8, 2022 10:11
c072a05
to
062f7bb
Compare
pkarashchenko
approved these changes
Dec 8, 2022
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
…oesn't change the container size Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
and ensure the internal state get clear if sz equals zero Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
…ntainer Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
since it is already done in video_framebuff_queue_container Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
…ue_vbuf_unsafe Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216
force-pushed
the
camera2
branch
from
December 8, 2022 12:10
062f7bb
to
b6b9818
Compare
@pkarashchenko could you merge this pr? |
pkarashchenko
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Minor
Testing
Pass CI