Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change for video framebuff #7776

Merged
merged 6 commits into from Dec 13, 2022
Merged

Conversation

xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 commented Dec 4, 2022

Summary

  • drivers/video: Zero all video_framebuff_t fields in video_framebuff_init
  • drivers/video: Remove the redundant vbuf_alloced != NULL check from video_framebuff_realloc_container
  • drivers/video: Clear the internal state if video_framebuff_realloc_container fail
  • driver/video: Merge vbuf_next assignment in video_framebuff_queue_container
  • drivers/video: Don't need update vbuf_tail in dequeue_vbuf_unsafe
  • drivers/video: Zero next field of dequeued buffer before return dequeue_vbuf_unsafe

Impact

Minor

Testing

Pass CI

Copy link
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

drivers/video/video_framebuff.c Outdated Show resolved Hide resolved
drivers/video/video_framebuff.c Show resolved Hide resolved
drivers/video/video_framebuff.c Show resolved Hide resolved
drivers/video/video_framebuff.c Show resolved Hide resolved
drivers/video/video_framebuff.c Show resolved Hide resolved
drivers/video/video_framebuff.c Outdated Show resolved Hide resolved
drivers/video/video_framebuff.c Show resolved Hide resolved
drivers/video/video_framebuff.c Outdated Show resolved Hide resolved
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
…oesn't change the container size

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
and ensure the internal state get clear if sz equals zero

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
…ntainer

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
since it is already done in video_framebuff_queue_container

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
…ue_vbuf_unsafe

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
Copy link
Contributor Author

@pkarashchenko could you merge this pr?

@pkarashchenko pkarashchenko merged commit 1555c9b into apache:master Dec 13, 2022
@xiaoxiang781216 xiaoxiang781216 deleted the camera2 branch December 14, 2022 02:28
@jerpelea jerpelea added this to To-Add in Release Notes - 12.1.0 Apr 3, 2023
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 12.1.0 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants