register notelog device #7981
Merged
register notelog device #7981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gary-Hobson
force-pushed
the
notelog
branch
2 times, most recently
from
67208d1
to
688c2fd
Compare
Gary-Hobson
force-pushed
the
notelog
branch
4 times, most recently
from
86db01b
to
a5ad161
Compare
syslog is a system call, which will cause recursion after turning on SCHED_INSTRUMENTATION_SYSCALL Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
xiaoxiang781216
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Register notelog to the list of note drivers
Impact
still only one note driver can be used
multi-channel functionality needs to wait for sysview changes to complete
patch 1 removes syscall_enter/leave in notelog, because syslog is a system call, which causes recursion.
patch 2 turns the original notelog function into a function pointer call to support simultaneous use with noteram/sysview
Testing
sim:note