Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executable permissions from source files #8363

Merged
merged 1 commit into from Jan 30, 2023

Conversation

hartmannathan
Copy link
Contributor

Summary

Remove executable permissions from the following source files:

  • arch/arm/src/sama5/sam_flexcom_spi.h
  • arch/risc-v/src/mpfs/mpfs_ihc_sbi.c
  • drivers/usbdev/adb.c
  • libs/libc/math/lib_scalbn.c
  • libs/libc/math/lib_scalbnf.c
  • net/ipfrag/Make.defs
  • net/ipfrag/ipfrag.c
  • net/ipfrag/ipfrag.h
  • net/ipfrag/ipv4_frag.c
  • net/ipfrag/ipv6_frag.c

Impact

Improves correctness.

Testing

N/A

* arch/arm/src/sama5/sam_flexcom_spi.h,
  arch/risc-v/src/mpfs/mpfs_ihc_sbi.c,
  drivers/usbdev/adb.c,
  libs/libc/math/lib_scalbn.c,
  libs/libc/math/lib_scalbnf.c,
  net/ipfrag/Make.defs,
  net/ipfrag/ipfrag.c,
  net/ipfrag/ipfrag.h,
  net/ipfrag/ipv4_frag.c,
  net/ipfrag/ipv6_frag.c: Remove executable permission.
@xiaoxiang781216
Copy link
Contributor

@hartmannathan can we add the check to tools/checkpatch.sh?

@hartmannathan
Copy link
Contributor Author

@hartmannathan can we add the check to tools/checkpatch.sh?

It would be nice to add it. Unfortunately I can't add it right now because of other work. I'll create an issue to track it until I (or someone else) can get to it...

@hartmannathan
Copy link
Contributor Author

@hartmannathan can we add the check to tools/checkpatch.sh?

Filed as Issue #8365

@acassis acassis merged commit 6b89b6f into apache:master Jan 30, 2023
@hartmannathan hartmannathan deleted the fix-exec-perms branch February 7, 2023 21:27
@jerpelea jerpelea added this to To-Add in Release Notes - 12.1.0 Apr 3, 2023
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 12.1.0 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants